After President Obama's election in 2008, there was a widespread hope that it would mark an end to unseemly partisan nastiness.