History chalks up Mr. McKinley's War as a U.S. win, and he also polls favorably as a 'near great' president.